Skip to content

Add support for SimpleCov 1.0 #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateusdeap merged 2 commits into from
Jul 31, 2026
Merged

Add support for SimpleCov 1.0 #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56737b8
Add support for simplecov 1.0
mateusdeap Jul 28, 2026
68de70a
Add CHANGELOG.md entry
mateusdeap Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# main [(unreleased)](https://github.com/fastruby/next_rails/compare/v1.6.0...main)

- [BUGFIX: example](https://github.com/fastruby/next_rails/pull/<number>)
- [FEATURE: Add support for SimpleCov 1.0](https://github.com/fastruby/next_rails/pull/196)
- [FEATURE: Validate the DeprecationTracker mode at initialization, treating a blank mode as the default `save`](https://github.com/fastruby/next_rails/pull/186)
- [BUGFIX: `bundle_report outdated` no longer confuses a locally-sourced (`path:`) gem with a same-named public gem on rubygems; local gems are excluded from the out-of-date check and counted separately](https://github.com/fastruby/next_rails/pull/189)

Expand Down
2 changes: 1 addition & 1 deletion next_rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "bundler", ">= 1.16"
spec.add_development_dependency "rake"
spec.add_development_dependency "rspec", "~> 3.0"
spec.add_development_dependency "simplecov", "~> 0.17.1"
spec.add_development_dependency "simplecov", ">= 0.17.1"

@JuanVqz JuanVqz Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding this or even being more strict?

Suggested change
spec.add_development_dependency "simplecov", ">= 0.17.1"
spec.add_development_dependency "simplecov", ">= 0.17.1", "< 2"

@JuanVqz JuanVqz Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actionable on our end, but v1 also deprecated the track_files in favor of cover just in case at some point we are required to switch to it, we can continue using track_files for our legacy Ruby's with:

 SimpleCov.respond_to?(:cover) ? SimpleCov.cover("lib/**/*.rb") : SimpleCov.track_files("lib/**/*.rb")

spec.add_development_dependency "timecop", "~> 0.9.1"
spec.add_development_dependency "byebug"
spec.add_development_dependency "rexml", "3.2.5" # limited on purpose, new versions don't work with old rubies
Expand Down
Loading