Skip to content

feat: AI advisor integration and architecture improvements #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yairfalse merged 5 commits into from
Feb 28, 2026
Merged

feat: AI advisor integration and architecture improvements #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4a1019
docs: rewrite CLAUDE.md to match current architecture
yairfalse Feb 21, 2026
cbed413
refactor: replace inline FALSE Protocol types with false-protocol crate
yairfalse Feb 25, 2026
8874280
merge: resolve CLAUDE.md conflict (false-protocol replaces ulid)
yairfalse Feb 25, 2026
02496ff
docs: document false-protocol sibling clone in README
yairfalse Feb 26, 2026
7cd9874
feat: add AI advisor integration with progressive adoption ladder
yairfalse Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ cargo fmt && cargo clippy -- -D warnings && cargo test
| `axum` 0.8 | HTTP server |
| `cdevents-sdk` | CDEvents emission |
| `reqwest` | HTTP client |
| `ulid` | ULID generation for FALSE Protocol |
| `false-protocol` | FALSE Protocol occurrence types |
| `chrono` | Timestamp handling |
| `thiserror` | Error types |
| `async-trait` | Async trait support |
13 changes: 12 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ async-trait = "0.1"
# Prometheus metrics
prometheus = "0.13"

# FALSE Protocol (ULID generation for occurrence IDs)
ulid = "1"
# FALSE Protocol occurrence types
false-protocol = { path = "../false-protocol/rust" }

Copilot AI Feb 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The false-protocol dependency uses a relative path (../false-protocol/rust), which makes the project unbuildable unless the false-protocol crate is available at that specific relative location. This creates tight coupling and makes it difficult for others to build, test, or contribute to this project.

Consider one of these alternatives:

  1. Publish the false-protocol crate to crates.io and reference it by version
  2. Use a git dependency with a repository URL if the crate is in a separate repo
  3. Move the false-protocol code into a workspace if both crates are meant to be maintained together
  4. Document the repository structure requirements clearly in the README if the relative path is intentional for development

Copilot uses AI. Check for mistakes.

[dev-dependencies]
serde_yaml = "0.9"
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ Part of the [False Systems](https://github.com/false-systems) toolchain.
## Quick Start

```bash
# Clone and build
# Clone KULTA and its sibling dependency
git clone https://github.com/false-systems/kulta
git clone https://github.com/false-systems/false-protocol
cd kulta
cargo build --release

Expand Down
37 changes: 37 additions & 0 deletions deploy/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,33 @@ spec:

Compatible with Argo Rollouts API for easy migration'
properties:
advisor:
default:
level: 'Off'
timeoutSeconds: 0
description: AI advisor configuration for progressive AI adoption
properties:
endpoint:
description: URL of AI advisory service (e.g., MCP endpoint, HTTP
API)
nullable: true
type: string
level:
default: 'Off'
description: Advisor integration level
enum:
- 'Off'
- Context
- Advised
- Planned
- Driven
type: string
timeoutSeconds:
description: Timeout for advisory calls in seconds
format: uint64
minimum: 0.0
type: integer
type: object
maxSurge:
description: 'Maximum number of pods that can be scheduled above the
desired number during update.
Expand Down Expand Up @@ -9865,6 +9892,11 @@ spec:
- timestamp
type: object
type: array
lastDecisionSource:
description: Source of last analysis decision (Threshold, Advisor,
Human)
nullable: true
type: string
message:
description: Human-readable message
nullable: true
Expand Down Expand Up @@ -19780,6 +19812,11 @@ spec:
- timestamp
type: object
type: array
lastDecisionSource:
description: Source of last analysis decision (Threshold, Advisor,
Human)
nullable: true
type: string
message:
description: Human-readable message
nullable: true
Expand Down
Loading
Loading