Skip to content

fix: close cross-validation executor pools - #2745

Open
mameikagou wants to merge 1 commit into
facebook:mainfrom
mameikagou:fix/cross-validation-pool-cleanup
Open

fix: close cross-validation executor pools#2745
mameikagou wants to merge 1 commit into
facebook:mainfrom
mameikagou:fix/cross-validation-pool-cleanup

Conversation

@mameikagou

Copy link
Copy Markdown

Fixes #2355.

This applies the executor cleanup proposed in #2738 and adds focused regression coverage.

What changed

  • Shut down internally created thread and process executors after cross-validation, including error paths.
  • Preserve caller-owned executors and Dask clients.
  • Cover repeated runs, mapping failures, and caller-owned executors.

Verification

  • Focused diagnostics tests: 5 passed
  • Python compile check
  • git diff --check

@meta-cla

meta-cla Bot commented Aug 27, 2026

Copy link
Copy Markdown

Hi @mameikagou!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using cross_validation results in OSError: [Errno 24] Too many open files

1 participant