Skip to content
This repository was archived by the owner on Sep 3, 2026. It is now read-only.

IBX-3265: Fixed translation of User Content Objects - #2081

Open
webhdx wants to merge 5 commits into
2.3from
IBX-3265_Translation_of_User_Content_Objects_is_not_possible
Open

IBX-3265: Fixed translation of User Content Objects#2081
webhdx wants to merge 5 commits into
2.3from
IBX-3265_Translation_of_User_Content_Objects_is_not_possible

Conversation

@webhdx

@webhdx webhdx commented Nov 29, 2022

Copy link
Copy Markdown
Contributor
Question Answer
Tickets https://issues.ibexa.co/browse/IBX-3265
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This is a complementary PR to: ezsystems/ezplatform-content-forms#63

Main change here changes translation to use correct route ezplatform.content.translate when using autosave option. To prevent creating new drafts, it'll accept versionNo parameter now and use requested draft for editing.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@webhdx
webhdx marked this pull request as ready for review November 30, 2022 07:56
@webhdx
webhdx requested a review from a team November 30, 2022 07:57
@ViniTou
ViniTou requested a review from a team November 30, 2022 09:33
}

$contentDraft = $this->contentService->createContentDraft($data->content->contentInfo);
if ($data->content->getVersionInfo()->status === VersionInfo::STATUS_DRAFT) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$data->content can be a variable since it's used in all cases.

@konradoboza
konradoboza requested a review from a team November 30, 2022 09:41
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bogusez

bogusez commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

Regression tests passed: ibexa/commerce#168

@bogusez bogusez removed their assignment Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

7 participants