changed audio playAndRecord mode from .default to .voiceChat#281
Merged
Conversation
using default doesn't sound good, you end up with a hiss
Contributor
Author
|
@f3dm76 hi alisa, can i get this merged and a new tag out, many thanks Fred |
Collaborator
|
Sure, I though you closed this one, sorry, have a great day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applies echo cancellation and noise reduction, removes the background hiss from recording.
using .default the recording ends up with a background hiss, doesn't sound good
@f3dm76 Thanks for your contributions to this great library, and your reviews