Skip to content

fix csg build - #16

Open
LinJiarui wants to merge 1 commit into
evanw:masterfrom
smartaec:master
Open

LinJiarui wants to merge 1 commit into
evanw:masterfrom
smartaec:master

Conversation

@LinJiarui

Copy link
Copy Markdown

resolve the following issue:
when build 2 or more coplanar polygons, the original method maybe split all the polygons into the front node (or the back node), thus leads to stackoverflow.

resolve the following issue:
when build 2 or more coplanar polygons, the original method maybe split all the polygons into the front node (or the back node), thus leads to stackoverflow.
@bhouston

bhouston commented Mar 9, 2015

Copy link
Copy Markdown

We are trying to make a centralized active repository here: https://github.com/csg-js/csg.js

@LinJiarui

Copy link
Copy Markdown
Author

So, should I create a new pull request for the active repository?

@stefnotch

Copy link
Copy Markdown

This PR causes doesn't handle coplanar polygons correctly.
The following script shows this rather nicely:

var a = CSG.cube();
var b = CSG.cube({ center: [-0.25, 0, -0.25] });
a.setColor(1, 1, 0);
b.setColor(0, 0.5, 1);
return a.subtract(b);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants