Allow custom apps to opt into app tests#4259
Merged
Merged
Conversation
Collaborator
|
Sounds good, tagging @gfwilliams with this being a more core change |
Member
|
Looks good - thanks! Does this need documenting somewhere though? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test.jsonfiles to explicitly opt custom apps intobin/runapptests.jsby settingallowCustomApp.app.idinstead of the undefinedappIdvariable.Rationale
Some custom apps still have deterministic packaged defaults and emulator-testable storage/module behavior. This keeps custom apps blocked by default while allowing app authors to opt into the documented test runner when their test intentionally covers the metadata/default-storage path rather than customizer-generated content.
Validation
node -c bin/runapptests.jsnode bin/runapptests.js --id demoappfortestformatgit diff --check