Skip to content

Allow custom apps to opt into app tests#4259

Merged
gfwilliams merged 1 commit into
espruino:masterfrom
zyf0717:allow-custom-app-tests
Jun 22, 2026
Merged

Allow custom apps to opt into app tests#4259
gfwilliams merged 1 commit into
espruino:masterfrom
zyf0717:allow-custom-app-tests

Conversation

@zyf0717

@zyf0717 zyf0717 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Allow test.json files to explicitly opt custom apps into bin/runapptests.js by setting allowCustomApp.
  • Keep the existing default behavior for custom apps that do not opt in.
  • Fix the custom-app error path to report app.id instead of the undefined appId variable.

Rationale

Some custom apps still have deterministic packaged defaults and emulator-testable storage/module behavior. This keeps custom apps blocked by default while allowing app authors to opt into the documented test runner when their test intentionally covers the metadata/default-storage path rather than customizer-generated content.

Validation

  • node -c bin/runapptests.js
  • node bin/runapptests.js --id demoappfortestformat
  • git diff --check

@zyf0717 zyf0717 marked this pull request as ready for review June 22, 2026 06:17
@bobrippling

Copy link
Copy Markdown
Collaborator

Sounds good, tagging @gfwilliams with this being a more core change

@gfwilliams

Copy link
Copy Markdown
Member

Looks good - thanks! Does this need documenting somewhere though?

@gfwilliams gfwilliams merged commit 7d0eadd into espruino:master Jun 22, 2026
2 checks passed
@zyf0717 zyf0717 deleted the allow-custom-app-tests branch June 23, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants