CoreTemp: refactor BLE runtime and added ANT+ HRM configurator#4255
Open
zyf0717 wants to merge 1 commit into
Open
CoreTemp: refactor BLE runtime and added ANT+ HRM configurator#4255zyf0717 wants to merge 1 commit into
zyf0717 wants to merge 1 commit into
Conversation
Author
|
@ihewitt looping you in as the original CoreTemp author. This PR substantially refactors CoreTemp’s BLE lifecycle and adds ANT+ HRM configuration/control-point support. I’d appreciate your review, especially around whether the new runtime ownership model, reconnect/cache behavior, and settings UX still fit the app’s intended design. For detailed docs please see README.md. |
d77a674 to
2124ae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coretemp.hrm.json, add deployable runtime modules, and bump CoreTemp to0.10.Validation
npm test