fix: shorten sv_SE speed unit and improve usage stats submission reliability#4254
Merged
gfwilliams merged 1 commit intoJun 19, 2026
Merged
Conversation
Collaborator
|
LGTM, and your fix has been validated by the CI run :) Shall let @gfwilliams approve since this touches core files |
Member
|
Thanks! Yes, this looks good! In general I wouldn't go around changing XMLHttpRequest to |
gfwilliams
added a commit
that referenced
this pull request
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two technical issues:
The 'sv_SE' speed unit was defined as 'km/tim' (6 characters), which exceeded the 5-character limit enforced by the sanity check script, leading to a known error. It has been updated to 'km/h' (4 characters), satisfying the validation requirement.
The 'sendUsageStats' function in 'loader.js' used the deprecated 'XMLHttpRequest' API and incorrectly updated the 'submittedUsageInfo' state even when the POST request failed. This prevented retries of failed analytics submissions. The function has been modernized to use 'fetch' with async/await, and it now only updates 'submittedUsageInfo' upon successful completion of the request.