Run the job in a container (required by the hardened cirrus runner) - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
arc-runner-espm157self-hosted runner no longer runs Docker-in-Docker.It previously ran a
docker:dindsidecar withprivileged: true, so anyworkflow landing on it could reach a privileged Docker socket and become root on
cirrus — the cluster's only node and its control plane. For a runner executing
student-authored coursework that is the worst place to have that property, so it
now uses ARC's
containerMode: kubernetes, where each job runs as its ownKubernetes pod.
Consequence for workflows: a job container is now mandatory
(
ACTIONS_RUNNER_REQUIRE_JOB_CONTAINER=true), and a job withoutcontainer:fails at startup. This adds
container: rocker/ml, the same imageespm-157/climate-python-template declares in its devcontainer. That exact image
was verified end to end on this runner against an identical workflow
(checkout -> setup-python 3.11.9 -> pip install -r requirements.txt -> pytest),
all steps passing.
This also repairs the
runs-onlabel, which was broken independently of theabove.
It pointed at
arc-runner-espm157-f24, a Fall-2024 one-off scale set that has been decommissioned, so no runner would ever pick the job up.