Select runner and container by org and repo visibility - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the workflow work in three places instead of one: this public template
repo, private student repos in espm-157, and any other instructor's copy.
Previously
runs-on: arc-runner-espm157was hardcoded. That runner exists onlyin this org and, since it was hardened, only accepts private repos — so this
public template's own CI hung forever, and so did any copy another instructor
generated, because that runner does not exist in their org at all.
Now both the runner and the container are selected from context:
arc-runner-espm157+container: rocker/ml(the course environment, on our cluster)
ubuntu-latest, no container, usingactions/setup-pythonThe container is deliberately dropped on the hosted path.
rocker/mlruns asjovyan(uid 1000) while the Actions workspace is owned byrunner(uid 1001),so on a GitHub-hosted runner it fails with
EACCES: permission denied, open '/__w/_temp/_runner_file_commands/...'
The only fix there is
options: --user ..., which ARC's kubernetes modeforbids. On the self-hosted side the uid is set in the runner's hook pod
template instead, which is why the container works there and is not needed here.
Both paths verified green before opening: this branch on
ubuntu-latest(checkout, setup-python, pip install, pytest), and the self-hosted path on a
private espm-157 repo with the same steps.