EPMDEDP-17146: fix: garbage-collect GitServer credentials Secret on deletion#288
Merged
Merged
Conversation
…eletion The GitServer reconciler now sets the GitServer as the controller owner of its credentials Secret (spec.nameSshKeySecret). Kubernetes then garbage-collects the Secret whenever the GitServer is deleted, regardless of the deletion path (portal UI, kubectl, or CLI). Previously the native K8s Secret was orphaned, which made recreating a Git integration with the same name fail with "resource already exists". Ownership is skipped when: - the Secret does not exist yet (set on a later reconcile, not a failure); - the Secret is already controlled by another resource (e.g. an ExternalSecret managed by the External Secrets Operator), or by this GitServer already; - the Secret is referenced by more than one GitServer, so deleting one does not garbage-collect credentials still in use by the others. Signed-off-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
SergK
force-pushed
the
EPMDEDP-17146-gitserver-secret-ownerref
branch
from
f59ed76 to
49f32e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitServer reconciler now sets the GitServer as the controller owner of its credentials Secret (spec.nameSshKeySecret). Kubernetes then garbage-collects the Secret whenever the GitServer is deleted, regardless of the deletion path (portal UI, kubectl, or CLI). Previously the native K8s Secret was orphaned, which made recreating a Git integration with the same name fail with "resource already exists".
Ownership is skipped when: