feat: support client and overall tracing sampling#9402
Open
Ri7ay wants to merge 6 commits into
Open
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Zakhar Zakharov <zakhar.zakharov.zz16@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9402 +/- ##
==========================================
+ Coverage 75.33% 75.38% +0.04%
==========================================
Files 252 252
Lines 41471 41481 +10
==========================================
+ Hits 31243 31270 +27
+ Misses 8115 8101 -14
+ Partials 2113 2110 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ri7ay
force-pushed
the
client-overall-tracing-sampling
branch
from
c4b0557 to
5629244
Compare
zirain
reviewed
Jul 1, 2026
Signed-off-by: Zakhar Zakharov <zakhar.zakharov.zz16@gmail.com>
zirain
approved these changes
Jul 2, 2026
zirain
left a comment
zirain
left a comment
Member
There was a problem hiding this comment.
Looks good, would be better if we could have e2e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for configuring Envoy tracing
client_samplingandoverall_samplingin addition to the existingrandom_samplingsupport.Envoy Gateway already exposes
samplingRate/samplingFraction, which maps to Envoy HCMrandom_sampling. This change adds new optional client and overall sampling settings so userscan control traces requested by clients and the final overall trace volume sent to collectors.
The PR updates:
EnvoyProxytracing API withclientSamplingRate,overallSamplingRate,clientSamplingFraction, andoverallSamplingFractionBackendTrafficPolicyroute tracing withclientSamplingFractionandoverallSamplingFractionWhich issue(s) this PR fixes:
Fixes #9372
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.