fix: handle EC parameters before TLS private keys#9338
Open
jvlxz wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 886f3e1be0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9338 +/- ##
=======================================
Coverage 75.17% 75.18%
=======================================
Files 252 252
Lines 41049 41062 +13
=======================================
+ Hits 30860 30873 +13
- Misses 8094 8095 +1
+ Partials 2095 2094 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Jules Dutel <jules.dutel@numberly.com>
Signed-off-by: Jules Dutel <jules.dutel@numberly.com>
jvlxz
force-pushed
the
tls-key-ec-parameters
branch
from
74f33fc to
5a71558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
What this PR does / why we need it:
This PR fixes TLS Secret parsing when an ECDSA private key contains an
EC PARAMETERSPEM block before the actual private key block.Some tools, including OpenSSL workflows, can produce
tls.keydata shaped like:Envoy Gateway previously decoded only the first PEM block from
tls.key. When that first block wasEC PARAMETERS, the Secret was rejected becauseEC PARAMETERSis not a private key format. That caused the Gateway listener to report an invalid certificate reference even though the same Secret also contained a validEC PRIVATE KEYblock.The fix changes TLS key parsing to scan through PEM blocks and use the first supported private key block:
PRIVATE KEY,RSA PRIVATE KEY, orEC PRIVATE KEY. If no supported private key block exists, Envoy Gateway still returns the existing validation error path using the first decoded PEM block type, so invalid Secrets continue to fail clearly.This keeps compatibility with existing PKCS1, PKCS8, and EC private keys while accepting EC keys that include leading EC parameters.
Tests:
go test ./internal/gatewayapitls.keystarts withEC PARAMETERSWhich issue(s) this PR fixes:
Fixes #
Release Notes: No