Support SIA#2
Conversation
|
When I tried to fix at https://github.com/ensdomains/content-hash/tree/sia , the test failed as follows. NOTE: When I updated multicodec to 2.0.0, it raised all sorts of different errors. |
|
@peterjanbrone Are you able to help us resolve this? We'd love to add Sia support |
|
Ok, from what I can gather from our Discord discussion, to get SIA support in our Content record, we need to first get SIA support in multicodec, which will allow us to add it to content-hash, which will allow us to add it to our Manager for the Content record. The main block is multicodec, which is here multiformats/multicodec#198 |
|
Ok, SIA is now included in multicodec. Anything else we need to do to get this merged and get SIA available for our Content record? @makoto |
| "dependencies": { | ||
| "cids": "^0.8.3", | ||
| "multicodec": "^1.0.4", | ||
| "multicodec": "^2.1.0", |
There was a problem hiding this comment.
This update causes a bunch of test failures. It seems that the format changed causing breakage in most if not all of the encode-decode functions. Not sure what to do here.
| */ | ||
| skynet: (value) => { | ||
| const multihash = multiH.encode(hexStringToBuffer(value), 'keccak-256'); | ||
| return new CID(1, 'skynet-ns', multihash).buffer; |
There was a problem hiding this comment.
This is still not working, even after updating all of the multicodec libraries. It's not working because obviously it depends on the cids package which we have not updated. Before going further I want to first make sure we even need a CID? I am not aware on what that is and why we would need it.
More information here as well: multiformats/multicodec#198
There was a problem hiding this comment.
skynet-ns which you added into multicodec looks like a protocode (or namespace), but CID seems taking content type which you didn't seem to add as swarm team added
This is swarm
And this is Skynet
There was a problem hiding this comment.
Before going further I want to first make sure we even need a CID? I am not aware on what that is and why we would need it.
I think we do, otherwise we won't be able to differentiate whether which protocol the given data is and CID seems prepending these protocol names.
More detail is on https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1577.md
| "author": "pldespaigne", | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "cids": "^0.8.3", |
There was a problem hiding this comment.
You need to update this to the latest (1.1.5) as it also has dependencies to multicodec.
|
this can be closed as it was done in #7 |
9a80900 to
7a941a7
Compare



No description provided.