NXT-12127: Added size prop for large overlay popup in Alert #370
Open
vJIYEv wants to merge 6 commits into
Open
NXT-12127: Added size prop for large overlay popup in Alert #370vJIYEv wants to merge 6 commits into
size prop for large overlay popup in Alert #370vJIYEv wants to merge 6 commits into
Conversation
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #370 +/- ##
===========================================
+ Coverage 82.07% 82.08% +0.01%
===========================================
Files 153 153
Lines 7507 7513 +6
Branches 2262 2267 +5
===========================================
+ Hits 6161 6167 +6
Misses 1041 1041
Partials 305 305 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Large overlay type Alert is needed.
Resolution
Regarding to the GUI guide, we need 3 types of overlay Alert: small, medium, large
So I added
sizeprop for overlay type.Additional Considerations
I updated other Alert GUI styles as well as the large overlay type.
Links
NXT-12127
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)