Skip to content

NXT-15800: Added react-is dependency #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-stoian-lgp wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

NXT-15800: Added react-is dependency #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
124b49f
added react-is as a dependency and modified jest config to use the in…
daniel-stoian-lgp Jun 12, 2026
38bbdc1
added react-is as a dependency and modified jest config to use the in…
daniel-stoian-lgp Jun 12, 2026
3f30de2
added react-is as a dependency and modified jest config and webpack c…
daniel-stoian-lgp Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/jest/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ module.exports = {
'^@testing-library/react$': require.resolve('@testing-library/react'),
'^@testing-library/user-event$': require.resolve('@testing-library/user-event'),
'^react$': require.resolve('react'),
'^react-is$': require.resolve('react-is'),
// Backward compatibility for new iLib location with old Enact
'^ilib[/](.*)$': path.join(app.context, globals.ILIB_BASE_PATH, '$1'),
// Backward compatibility for old iLib location with new Enact
Expand Down
12 changes: 9 additions & 3 deletions config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,9 +360,15 @@
symlinks: false,
// Backward compatibility for apps using new ilib references with old Enact
// and old apps referencing old iLib location with new Enact
alias: fs.existsSync(path.join(app.context, 'node_modules', '@enact', 'i18n', 'ilib')) ?
Object.assign({ilib: '@enact/i18n/ilib'}, app.alias) :
Object.assign({'@enact/i18n/ilib': 'ilib'}, app.alias),
alias: Object.assign(
{
'react-is': path.dirname(require.resolve('react-is/package.json'))
},
fs.existsSync(path.join(app.context, 'node_modules', '@enact', 'i18n', 'ilib'))
? {ilib: '@enact/i18n/ilib'}

Check warning on line 368 in config/webpack.config.js

View workflow job for this annotation

GitHub Actions / branch / test (node) 

'?' should be placed at the end of the line

Check warning on line 368 in config/webpack.config.js

View workflow job for this annotation

GitHub Actions / pull-request / test (node) 

'?' should be placed at the end of the line
: {'@enact/i18n/ilib': 'ilib'},

Check warning on line 369 in config/webpack.config.js

View workflow job for this annotation

GitHub Actions / branch / test (node) 

':' should be placed at the end of the line

Check warning on line 369 in config/webpack.config.js

View workflow job for this annotation

GitHub Actions / pull-request / test (node) 

':' should be placed at the end of the line
app.alias
),
// Optional configuration for redirecting module requests.
fallback: app.resolveFallback
},
Expand Down
73 changes: 37 additions & 36 deletions npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"react": "^19.2.4",
"react-dev-utils": "^12.0.1",
"react-dom": "^19.2.4",
"react-is": "^19.2.4",
"react-refresh": "^0.18.0",
"react-test-renderer": "^19.2.4",
"resolution-independence": "^1.0.0",
Expand Down
Loading