cmd/dkim-milter: Toggleable dkim verification - #82
Open
casKd-dev wants to merge 1 commit into
Open
Conversation
emersion
reviewed
Jul 23, 2026
| var err error | ||
| s.verifs, err = dkim.VerifyWithOptions(pr, &options) | ||
|
|
||
| if verify { |
Owner
There was a problem hiding this comment.
This unnecessarily creates a goroutine which copies to ioutil.Discard. Can we make it so pw is left nil instead, very much like signer?
Would be nice to rename it to verifier as well.
Author
There was a problem hiding this comment.
I am unsure what you mean to rename to verifier here. Could you be more specific?
emersion
reviewed
Jul 23, 2026
emersion
reviewed
Jul 23, 2026
casKd-dev
force-pushed
the
toggleable-dkim-verification
branch
from
August 5, 2026 11:00
7fc7a72 to
9955e30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: In my case i have multiple instances of go-msgauth running signing with multiple keys but it is present in every SMTP transcation as a milter, no matter if outbound or inbound
I achieve with this:
Outbound: rsa signer > ed25519 signer > rspamd > outbound
Inbound: ignored > ignored > rspamd > inbound
This prevents multiple layers of useless verifications and lets rspamd handle the verification instead for inbound mails