Repository navigation
Conversation
Saumya-R
force-pushed
the
saumya_showcase_baselibs
branch
from
October 26, 2026 17:04
2ec5726 to
d67ea37
Compare
Saumya-R
marked this pull request as ready for review
October 27, 2026 03:38
Saumya-R
requested review from
AlexanderLanin,
FScholPer,
MaximilianSoerenPollak,
PiotrKorkus,
antonkri,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
October 27, 2026 03:38
PiotrKorkus
requested changes
Oct 27, 2026
|
|
||
|
|
||
| @add_test_properties( | ||
| partially_verifies=["<baselibs stakeholder req id>"], |
| """...""" | ||
| run_showcases( | ||
| target, | ||
| "Baselibs Builtin Logger Example", |
Contributor
There was a problem hiding this comment.
I would split into separate test cases
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adds a standalone showcase for
score_baselibs, which was the only integrated module inknown_good.jsonwithout one, and adds an ITF test for it inplatform_integration_tests.Changes
Showcase
showcases/standalone/baselibs.score.json: new file with three examples:log_builtinsets up the built-in stdout logger and logs at every level, with a per-message context override.log_custominstalls a custom global logger and filters messages by level.log_cpp_initsets up the logger from C++ and logs from Rust code.showcases/standalone/BUILD: newbaselibsscore_pkg_bundlethat packages the three example binaries from@score_baselibs//examples.showcases/BUILD: registersbaselibs_pkg_filesin both theshowcasesbundle and theshowcases_bundlefilegroup (used for the QNX IFS).Platform integration test
platform_integration_tests/baselibs/BUILD: newpy_itf_test, built the same way as the existing tests (Docker on linux_x86_64, QEMU on qnx_x86_64).platform_integration_tests/baselibs/test_baselibs_showcase.py: runs all three examples through the showcase CLI and checks that each one finishes successfully.platform_integration_tests/BUILD: adds the new test to thepitsuite.baselibs patch
patches/baselibs/003-make-log-examples-visible.patch: makes//examples/log_builtin:log_builtinand //examples/log_custom:log_custompublic. Without it the bundle fails with a Bazel visibility error, because neither target setsvisibility. (log_cpp_init` is already public.)known_good.json: adds the patch toscore_baselibs.bazel_patches.bazel_common/score_modules_target_sw.MODULE.bazel: regenerated withscripts/known_good/update_module_from_known_good.py.Testing
bazel build //showcases/...on linux_x86_64bazel build //showcases/...on qnx_x86_64bazel test //platform_integration_tests/baselibson linux_x86_64bazel test //platform_integration_tests/baselibson qnx_x86_64/showcases/bin/cli --examples=...Open points
partially_verifies=["<stkh_req id>"].Reviewers, please confirm the right baselibs stakeholder requirement.