Repository navigation
fix(kvs): make unit tests pass on QNX targets - #586
Merged
Merged
Conversation
arkjedrz
commented
Oct 26, 2026
Contributor
- Rust: add test-only tempdir helper. On QNX it creates the directory in the cwd. QNX /tmp can't hold directories.
- C++: skip flush_failure_rotate_snapshots when run as root. Root ignores file permissions, so flush succeeds.
- C++: use ASSERT_FALSE so the test can't abort the binary.
arkjedrz
requested review from
PandaeDo,
antonkri,
umaucher and
vinodreddy-g
as code owners
October 26, 2026 09:43
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Contributor
|
Documentation preview for this pull request is available at: |
- Rust: add test-only tempdir helper. On QNX it creates the directory in the cwd. QNX /tmp can't hold directories. - C++: skip flush_failure_rotate_snapshots when run as root. Root ignores file permissions, so flush succeeds. - C++: use ASSERT_FALSE so the test can't abort the binary. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
arkjedrz
force-pushed
the
arkjedrz_tooling-08-fixes
branch
from
October 26, 2026 14:48
4b50523 to
239effe
Compare
umaucher
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.