Repository navigation
Conversation
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 12, 2026 08:05
7641148 to
dd82292
Compare
arkjedrz
marked this pull request as ready for review
October 12, 2026 09:48
arkjedrz
requested review from
PandaeDo,
antonkri,
umaucher and
vinodreddy-g
as code owners
October 12, 2026 09:48
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 12, 2026 10:13
dd82292 to
1283777
Compare
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 12, 2026 14:29
1283777 to
b00ca98
Compare
arkjedrz
had a problem deploying
to
workflow-approval
October 12, 2026 14:29 — with
GitHub Actions
Error
arkjedrz
had a problem deploying
to
workflow-approval
October 12, 2026 14:29 — with
GitHub Actions
Error
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 13, 2026 06:30
34471fd to
266b0ee
Compare
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 13, 2026 07:07
266b0ee to
8899453
Compare
Contributor
|
Documentation preview for this pull request is available at: |
PandaeDo
previously approved these changes
Oct 13, 2026
PandaeDo
left a comment
Contributor
There was a problem hiding this comment.
Fine from my perspective (understanding)
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 19, 2026 09:23
bf0b24c to
4e669c8
Compare
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 19, 2026 13:46
4e669c8 to
ca5ea41
Compare
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 20, 2026 12:29
ca5ea41 to
58d8f14
Compare
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 21, 2026 06:06
58d8f14 to
86415ee
Compare
arkjedrz
had a problem deploying
to
workflow-approval
October 21, 2026 06:07 — with
GitHub Actions
Error
arkjedrz
had a problem deploying
to
workflow-approval
October 21, 2026 06:07 — with
GitHub Actions
Error
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 21, 2026 06:58
86415ee to
a556ee8
Compare
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 21, 2026 11:57
a556ee8 to
4184525
Compare
arkjedrz
had a problem deploying
to
workflow-approval
October 21, 2026 11:58 — with
GitHub Actions
Error
arkjedrz
had a problem deploying
to
workflow-approval
October 21, 2026 11:58 — with
GitHub Actions
Error
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 21, 2026 15:46
4184525 to
0a51d63
Compare
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 22, 2026 06:12
0a51d63 to
566e20c
Compare
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 22, 2026 07:26
566e20c to
14a9cad
Compare
arkjedrz
force-pushed
the
arkjedrz_output-json-align
branch
from
October 22, 2026 10:13
14a9cad to
5393a50
Compare
- Disallow non-type-tagged representation. - Replace `From` with `TryFrom` for Rust type types. - Conversion is not infallible. - Add `kvsvalue_to_any` object specialization. - To avoid unnecessary copy. - Disallow duplicate keys in `KvsValue::Object`. - Update tests.
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FromwithTryFromfor Rust type types.kvsvalue_to_anyobject specialization.KvsValue::Object.KvsValue::Objectrepresentation is no longer aligned due to incomplete types used byunordered_mapbeing an UB.To be revisited once custom map container is available.