Repository navigation
Use anonymous shared memory - #867
Open
WilliamRoebuck wants to merge 3 commits into
Open
WilliamRoebuck wants to merge 3 commits into
WilliamRoebuck wants to merge 3 commits into
Conversation
WilliamRoebuck
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
October 27, 2026 09:46
WilliamRoebuck
had a problem deploying
to
workflow-approval
October 27, 2026 09:46 — with 
GitHub Actions
Error
GitHub Actions
Error
WilliamRoebuck
had a problem deploying
to
workflow-approval
October 27, 2026 09:46 — with
GitHub Actions
Error
GitHub Actions
Error
WilliamRoebuck
had a problem deploying
to
workflow-approval
October 27, 2026 09:46 — with
GitHub Actions
Error
GitHub Actions
Error
WilliamRoebuck
had a problem deploying
to
workflow-approval
October 27, 2026 09:46 — with
GitHub Actions
Error
GitHub Actions
Error
WilliamRoebuck
force-pushed
the
feature/anon-shared-mem
branch
from
October 27, 2026 09:57
fdc6100 to
6c02613
Compare
WilliamRoebuck
had a problem deploying
to
workflow-approval
October 27, 2026 09:57 — with
GitHub Actions
Error
GitHub Actions
Error
WilliamRoebuck
had a problem deploying
to
workflow-approval
October 27, 2026 09:57 — with
GitHub Actions
Error
GitHub Actions
Error
WilliamRoebuck
had a problem deploying
to
workflow-approval
October 27, 2026 09:57 — with
GitHub Actions
Error
GitHub Actions
Error
WilliamRoebuck
had a problem deploying
to
workflow-approval
October 27, 2026 09:57 — with
GitHub Actions
Error
GitHub Actions
Error
WilliamRoebuck
force-pushed
the
feature/anon-shared-mem
branch
from
October 27, 2026 10:07
6c02613 to
b5d753f
Compare
cameron-craig-etas
suggested changes
Oct 27, 2026
| namespace score::mw::lifecycle::internal::osal | ||
| { | ||
|
|
||
| /// @brief Open an anonymous shared memory file with (M)FD_CLOEXEC. |
Contributor
There was a problem hiding this comment.
nit: MFD_CLOEXEC is only for QNX. Maybe just drop the "with (M)FD_CLOEXEC" from the comment? Could mention how it is platform specific.
Suggested change
| /// @brief Open an anonymous shared memory file with (M)FD_CLOEXEC. | |
| /// @brief Open an anonymous shared memory file using OS-dependent implementations. |
| "object name."; | ||
| return false; | ||
| // Anonymous shared mem name is only used for debugging (or discarded on QNX). It does not need to be unique | ||
| LM_LOG_INFO() << "Shared memory name truncated: the local buffer is too small for the shared memory " |
Contributor
There was a problem hiding this comment.
Maybe a warning is more suitable?
| LM_LOG_INFO() << "Shared memory name truncated: the local buffer is too small for the shared memory " | ||
| "object name. Proceeding with generic name"; | ||
|
|
||
| shm_name = {"/ipc_shared_mem_OUTOFNUMBERS\0"}; |
Contributor
There was a problem hiding this comment.
nit: Suggesting a less confusing name
Suggested change
| shm_name = {"/ipc_shared_mem_OUTOFNUMBERS\0"}; | |
| shm_name = {"/ipc_shared_mem_generic_name\0"}; |
Contributor
|
Documentation preview for this pull request is available at: |
| "object name."; | ||
| return false; | ||
| // Anonymous shared mem name is only used for debugging (or discarded on QNX). It does not need to be unique | ||
| LM_LOG_INFO() << "Shared memory name truncated: the local buffer is too small for the shared memory " |
Contributor
There was a problem hiding this comment.
Is this name building still needed? In shm_open_anon.hpp is says "multiple
/// files can have the same name without any side effect" so can every anonymous shared memory get the same name?
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the move to platform-specific anonymous shared memory.
No open issues 🎉
What changed in this PR
This PR moves launch-manager IPC allocation to platform-specific anonymous shared memory, avoiding failures caused by shared-memory name collisions.
Changes:
- Adds
shm_open_anon, using Linuxmemfd_createand QNXO_ANON. - Updates process launching to use the abstraction and tolerate debug-name truncation.
- Adjusts build dependencies, syscall mocks, and tests for anonymous shared memory.
| File | Description |
|---|---|
tests/utils/mocks/mock_syscalls.hpp |
Adds a mock for shm_open_anon. |
tests/integration/process_fd_leak/reporting.cpp |
Updates the expected descriptor path to Linux memfd format. |
tests/integration/process_fd_leak/control_client_test_driver.cpp |
Updates the expected descriptor path to Linux memfd format. |
score/launch_manager/src/daemon/src/process_group_manager/details/process_launcher.cpp |
Uses anonymous allocation and adds a fallback debug name. |
score/launch_manager/src/daemon/src/process_group_manager/details/process_launcher_UT.cpp |
Replaces named-memory mock expectations with shm_open_anon. |
score/launch_manager/src/daemon/src/process_group_manager/details/BUILD |
Adds the anonymous-memory library dependency. |
score/launch_manager/src/daemon/src/osal/shm_open_anon.hpp |
Declares and documents the anonymous-memory interface. |
score/launch_manager/src/daemon/src/osal/details/qnx/shm_open_anon.cpp |
Implements allocation using QNX O_ANON. |
score/launch_manager/src/daemon/src/osal/details/linux/shm_open_anon.cpp |
Implements allocation using Linux memfd_create. |
score/launch_manager/src/daemon/src/osal/BUILD |
Selects the platform-specific implementation. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we create anonymous shared memory with
shm_open+shm_unlink. This can fail if the shared memory name is already in use.For anonymous shared memory, Linux provides
memfd_createand QNX theO_ANONflag to create shared memory without depending on a name.Added osal function
shm_open_anonto use the correct method for each OS.