[cameron-craig-etas]

#683

This PR enables warnings as errors for the list of warnings defined in score_cpp_policies.

• Warnings as errors are enforced for production code, and integration test code.
• Warnings are enabled for unit test code, but they remain warnings (not warnings as errors).
• For a successful build we rely on a recent change to baselibs, so we are using an unreleased commit hash until a release is available.
• We do what we can to ignore warnings from external sources, by setting the below config, but this does not ignore external warnings from headers that we include into our own build targets.

  build --per_file_copt=external/.*@-w
  build --host_per_file_copt=external/.*@-w
  

• All remaining warnings are fixed to allow the build to succeed.

[github-actions]

Documentation preview for this pull request is available at:
pr-862: https://eclipse-score.github.io/lifecycle/pr-862/

[danth]

All changes look good to me.

Are the warnings disabled also for integration tests as well as unit tests?

[cameron-craig-etas]

All changes look good to me.

Are the warnings disabled also for integration tests as well as unit tests?

The warnings actually enabled for integration tests. And the tests currently seem to be passing without any warnings. So I would be tempted to keep warnings as errors here. We are currently only removing the warnings as errors for the lm_cc_test wrapper.

[danth]

OK. I think we should aim to resolve all warnings in the unit tests too eventually

[cameron-craig-etas]

OK. I think we should aim to resolve all warnings in the unit tests too eventually

Yes I was thinking the same. I just didn't want to open that can of worms in this PR 😆