Skip to content

RLIMIT support - Part 2 - #847

Merged
MaciejKaszynski merged 5 commits into
eclipse-score:mainfrom
etas-contrib:rlimit_support_2
Oct 27, 2026
Merged

RLIMIT support - Part 2#847
MaciejKaszynski merged 5 commits into
eclipse-score:mainfrom
etas-contrib:rlimit_support_2

Conversation

@NicolasFussberger

@NicolasFussberger NicolasFussberger commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Adds the rlimit values to the internal flatbuffer format of the launch manager.
The values are not yet configurable via json.

This keeps - though ignores - the existing values max_memory_usage and max_cpu_usage.
There were never really supported and it was always documented in the known limitations:

  • The sandbox parameters max_memory_usage and max_cpu_usage are
    currently not supported and are ignored.

Next PR will completely remove these parameters.

For a complete example, see #785

@NicolasFussberger
NicolasFussberger marked this pull request as ready for review October 23, 2026 13:22
@github-actions

github-actions Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-847: https://eclipse-score.github.io/lifecycle/pr-847/

TimoSteuerwaldETAS
TimoSteuerwaldETAS reviewed Oct 26, 2026
View reviewed changes
Comment thread score/launch_manager/src/daemon/src/configuration/details/lm_flatcfg.fbs
Comment thread score/launch_manager/src/daemon/src/process_group_manager/details/process_launcher.cpp
Comment thread score/launch_manager/src/daemon/src/process_group_manager/details/process_launcher_UT.cpp
FScholPer
FScholPer reviewed Oct 27, 2026
View reviewed changes
Comment thread score/launch_manager/src/daemon/src/configuration/details/lm_flatcfg.fbs
//
// Members are prefixed with POSIX_ because they name the seven resource limits
// specified by POSIX.1.
enum RlimitResource : ubyte {

@FScholPer FScholPer Oct 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also covered by config and bundled within the metadata?

@NicolasFussberger NicolasFussberger Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this PR, but the next PR will make this configurable via the regular json config, which is then translated to the flatbuffer schema.
PR #785 has the complete changes, including a feature integration test that checks if rlimits were applied in the started process.

Comment thread score/launch_manager/src/daemon/src/process_group_manager/details/process_launcher_UT.cpp
RecordProperty("Description", "Verify that the forked process exits if setting a limit fails");

config_.deployment_config.sandbox.max_cpu_usage = 500;
config_.deployment_config.sandbox.rlimits = {

@FScholPer FScholPer Oct 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing with ITF in an qemu image would also make sense if the limits are really working

@NicolasFussberger NicolasFussberger Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is planned for the next PR. All changes are already in #785 but have been broken down into smaller PR for easier review.

MaciejKaszynski
MaciejKaszynski approved these changes Oct 27, 2026
View reviewed changes

@MaciejKaszynski MaciejKaszynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All open comments will be done in the next PR so merging

@MaciejKaszynski
MaciejKaszynski added this pull request to the merge queue Oct 27, 2026
Merged via the queue into eclipse-score:main with commit 5a3ebe2 Oct 27, 2026
13 of 17 checks passed
@MaciejKaszynski
MaciejKaszynski deleted the rlimit_support_2 branch October 27, 2026 09:33
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Oct 27, 2026

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — 0328f7f6 Waiting Oct 27, 2026 by NicolasFussberger via Build and test unit-tests-x86_64-qnx / approval #1823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FScholPer FScholPer FScholPer left review comments
@MaciejKaszynski MaciejKaszynski MaciejKaszynski approved these changes
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner
+1 more reviewer
@TimoSteuerwaldETAS TimoSteuerwaldETAS TimoSteuerwaldETAS approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NicolasFussberger @TimoSteuerwaldETAS @FScholPer @MaciejKaszynski