Remove internal ICU support from databinding API#3985
Merged
Conversation
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
vogella
force-pushed
the
icu
branch
2 times, most recently
from
6009db9 to
3efb1b0
Compare
Public ICU-based databinding API was removed in 2022. This change removes the remaining internal reflective support and documentation references to com.ibm.icu, completing the transition to java.text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public ICU-based databinding API was removed in 2022 (commit 616243f). This change removes the remaining internal reflective fallbacks to
com.ibm.icu.text.NumberFormatandcom.ibm.icu.math.BigDecimalinorg.eclipse.core.databinding, completing the transition tojava.text. Java 17 (the bundle's BREE) handlesBigDecimalparsing/formatting correctly viaDecimalFormat#setParseBigDecimal(true), which is already used. Also drops two stale Javadoc references that contrasted these classes with sibling classes that no longer exist.Planned for 4.41.