Repository navigation
Conversation
Fixes dynamicslab#703. Retain the documented functions attribute and old serialized libraries while making sklearn repr, clone and parameter updates agree.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #703.
CustomLibrarystores its functions asfunctions, but scikit-learn looks up the constructor parameterlibrary_functions. This breaks notebook display,clone()andset_params()on both 2.1.0 and current main:Expose
library_functionsas a read/write alias of the existingfunctionsattribute. This also makes parameter replacement affect the functions used byfitandtransform, while retaining the documented attribute and libraries saved by older versions.Fitted libraries cache generated
function_names. When changing the number of functions after a fit, also setfunction_names=Noneto regenerate names on the next fit.Checked fitted/unfitted cloning, parameter replacement, an old-writer serialized library, and cloning a fitted Lorenz model. Existing feature arrays, coefficients and predictions remain identical. A scikit-learn Pipeline/GridSearchCV on a recorded waveform now runs; both candidate scores agree with independently assembled matrices and NumPy least squares within
2e-16. This is an API check, not a physiological model.Validation: all three new regressions fail on base and pass here; feature-library tests: 93 passed, 1 skipped; configured pre-commit checks pass. The complete suite has the same 35 Gurobi
max_iterfailures on both revisions (base 709 passed, head 712 passed, both 13 skipped and 11 deselected).