refactor(utils): drop the dead exports — positioning, memo, composeHandlers - #66
Merged
Conversation
…ndlers None of them ever had a consumer: no target or component imports them, mergeProps composes handlers through its own private helper, and positioning was speculative vocabulary for floating components that don't exist yet. mergeProps is now the package's whole surface. Positioning comes back designed against a real floating component when one lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…de public (#67) Promote the private compose inside mergeProps to a public export in its own file. Same function, same semantics (consumer first, library skipped on the consumer's defaultPrevented): mergeProps now imports it, so nothing changes behaviorally — the composition just becomes reachable for consumers that need to compose a single handler pair outside a prop merge. Unlike the composeHandlers removed in the previous commit (a props-mutating walker with no veto that nothing ever called), this exports the battle-tested implementation the whole stack already runs on. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Conflict: the ARCHITECTURE.md project-structure table — main widened the columns and added solid to the targets row (#32), this branch trimmed the utils row to mergeProps + composeHandlers. Kept main's table with this branch's utils row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the three ever had a consumer:
Placement,Side,PositioningOptions,placementToSide,pickSide) — speculative vocabulary for floating components that don't exist yet; also the only util with no tests.memo— its only call sites were its own test file.composeHandlers— same;mergePropscomposes handlers through its own privatecompose, not this export.mergePropsis now the package's whole surface.ARCHITECTURE.mdupdated to match. Changeset is a minor for@dunky.dev/state-machine-utils(not patch): the symbols were publicly exported, so any external import of them breaks.Positioning will come back designed against a real floating component when one lands.
Full suite, typecheck, lint, format, and build all green.
🤖 Generated with Claude Code