Skip to content

CUR2-2667: remove optimism bridge mapping deps#9768

Open
tomfutago wants to merge 1 commit into
mainfrom
CUR2-2667-remove-optimism-bridge-mapping-deps
Open

CUR2-2667: remove optimism bridge mapping deps#9768
tomfutago wants to merge 1 commit into
mainfrom
CUR2-2667-remove-optimism-bridge-mapping-deps

Conversation

@tomfutago

@tomfutago tomfutago commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove Optimism price metadata's dependency on prices_optimism_tokens_bridged, leaving prices_optimism_tokens curated-only.
  • Remove tokens_optimism_erc20_bridged_mapping from generated Optimism ERC20 metadata.
  • Add explicit ERC20 curated entries for price-curated Optimism tokens that previously only reached tokens.erc20 through bridge-generated metadata.

Test plan

  • uv run dbt parse
  • uv run dbt compile --select prices_optimism_tokens tokens_optimism_erc20_generated tokens_optimism_erc20_curated
  • /review / Bugbot: no bugs found
  • 7709272: candidate price rows have 0 duplicate contracts and 0 BRIGHT rows; removing bridge-derived prices drops 94 current production bridge-only rows intentionally.
  • 7709273: candidate generated ERC20 has 0 bridge-source rows and all curated price rows are represented in candidate ERC20 metadata.
  • 7709367: the 16 new ERC20 curated rows do not duplicate existing curated or generated sources.
  • 7709539: row-count summary for price/generated ERC20 metadata removed by this change.
  • 7709549: net canonical Optimism ERC20 metadata removal after curated additions.

Regression test

  • 7709644: compares actual PR CI relations against production. Results match expected diffs: prices_optimism_tokens removes 94 bridge-only contracts, tokens_optimism_erc20_generated removes 319 bridge-derived contracts, and tokens_optimism_erc20_curated adds 16 explicit contracts.
  • 7709652: cross-model checks show 0 CI price duplicates, 0 BRIGHT price rows, 0 bridge-source generated rows, 0 price rows missing from CI ERC20 metadata, and 0 duplicate existing/generated sources among the 16 added curated rows.
  • 7709659: canonical ERC20 net diff shows Optimism ERC20 metadata changes from 793 production contracts to 602 CI contracts: 202 prod-only removals and 11 CI-only additions at the canonical union level.

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot marked this pull request as draft June 12, 2026 13:47
@github-actions github-actions Bot added WIP work in progress dbt: tokens covers the Tokens dbt subproject labels Jun 12, 2026
@tomfutago

Copy link
Copy Markdown
Contributor Author

dbt regression test results

Overall status: pass, with expected diffs only.

Models compared against actual PR CI relations from dune_spellbook_ci__tmp_pr9768_27419778084_1:

  • prices_optimism_tokens: prod 201, CI 107; 94 prod-only bridge-derived rows removed as intended; CI duplicate contracts 0.
  • tokens_optimism_erc20_generated: prod 481, CI 162; 319 prod-only bridge-derived rows removed as intended; CI duplicate contracts 0.
  • tokens_optimism_erc20_curated: prod 433, CI 449; 16 CI-only curated additions as intended; CI duplicate contracts 0.

Cross-model checks:

  • CI price rows missing from CI ERC20 metadata: 0
  • CI BRIGHT price rows: 0
  • CI generated rows with token_mapping_source = 'l2 bridge mapping': 0
  • Duplicate existing/generated sources among the 16 added curated rows: 0

Canonical Optimism ERC20 net diff:

  • Prod canonical ERC20 contracts: 793
  • CI canonical ERC20 contracts: 602
  • Prod-only removals: 202
  • CI-only additions: 11

Verification queries:

@tomfutago tomfutago marked this pull request as ready for review June 12, 2026 14:33
@github-actions github-actions Bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jun 12, 2026
@tomfutago tomfutago requested a review from a team June 12, 2026 14:33
@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dbt: tokens covers the Tokens dbt subproject ready-for-merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants