test(synology): raise test JVM heap to 1g to avoid OOM#1498
Merged
Conversation
simonxander
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Synology test suite OOMs in CI on
shouldThrowExceptionIfSendPostRequestFailed [2] VideoModel-- which was identified after investigation in #1495. This blocks the CI.uploadVideoChunkspre-allocates two 50MB byte arrays into a buffer pool on every call.shouldSendMultipleChunksForLargeVideoleaves ~150MB live (50MB content + 100MB pool).The next test immediately allocates another 100MB pool before GC has a chance to clear the previous one -- exceeding the default test JVM heap.
The
maxHeapSizesetting only affects the test JVM, not Gradle itself or production runtime.What's not fixed
The root cause --
uploadVideoChunkspre-allocating 100MB regardless of file size -- is a production-code issue. Lazy buffer allocation (allocate on demand, release after consumer finishes) would fix both the test OOM and the memory waste on small files.That's a more invasive change left for a follow-up.
cc @simonxander or @mengyushen -- let's discuss the 100MB buffer after the CI is unblocked.