Conversation
🦋 Changeset detectedLatest commit: ee0d1c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe Druxt collection cache now preserves dehydrated ChangesCollection cache rehydration
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Cached collection responses retain included resources consistently with initial responses, with no current merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b73aace to
0413057
Compare
0413057 to
ee0d1c8
Compare
Types of changes
Description
addCollectiondehydratedincludedresources intostate.resourcesbut then deleted them from the stored collection. So a secondgetCollectiondispatch for an already-cached query returnedincluded: undefined, and anything resolving an included resource, such as an image or media reference, silently got nothing back on the cache hit.This keeps the dehydrated
includedrefs on the stored collection and reconstructs them on a cache hit, the same waydataalready is. Includes a changeset.Resolves: #781
Checklist
Screenshots/Media
N/A
Summary by CodeRabbit