Mark TestRunners packages IsShipping and add package metadata - #1588
Open
amirvenus wants to merge 2 commits into
Open
Mark TestRunners packages IsShipping and add package metadata#1588amirvenus wants to merge 2 commits into
amirvenus wants to merge 2 commits into
Conversation
Companion to dotnet#1565 (coverage collection). Two TestRunners packages (Microsoft.DotNet.XHarness.TestRunners.Common and .Xunit) have not published to the dotnet-eng feed since 1.0.0-prerelease.23252.4 (2023-09-09), while Microsoft.DotNet.XHarness.CLI has continued publishing continuously up to 11.0.0-prerelease.26217.1+. Without these packages being republished, the device-side CoverageManager added in dotnet#1565 cannot reach consumers — the CLI side of --enable-coverage ships, but the test runner that actually produces the coverage report does not. This change: - Adds <IsShipping>true</IsShipping> to both TestRunners csprojs (makes the shipping intent explicit so it's visible in Arcade's asset manifest path). - Fills in <Description> and <PackageTags> so the packages publish with proper NuGet metadata when shipping resumes. Does not modify the publish pipeline itself; see the companion issue for the broader diagnosis and to confirm whether the gap is intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to the issue in #1587. This is a small, conservative change that:
<IsShipping>true</IsShipping>toMicrosoft.DotNet.XHarness.TestRunners.Common.csprojandMicrosoft.DotNet.XHarness.TestRunners.Xunit.csproj, making the shipping intent explicit.<Description>and<PackageTags>so the packages carry proper NuGet metadata.Context
Since 2023-09-09 neither package has been republished to the
dotnet-engfeed — the last published versions are1.0.0-prerelease.23252.4. Over the same windowMicrosoft.DotNet.XHarness.CLIhas continued publishing up to11.0.0-prerelease.26217.1. Full diagnosis is in #1587.This PR does not attempt to change the publish pipeline itself — I don't yet know whether the nupkgs are produced-but-filtered or simply not produced on your pipeline, and I don't want to guess. I'd appreciate a pointer from someone with access to a recent build log about whether these changes are enough on their own, or whether more plumbing is needed downstream.
Why this is still worth taking even if it doesn't fully fix publishing
IsShippingexplicit is a one-time hygiene improvement regardless — it removes any ambiguity between "intentional non-shipping" and "accidental non-shipping" for future readers.<Description>/<PackageTags>benefit consumers when these packages publish — whether that resumes via this PR, a follow-up, or a pipeline-side fix.Test plan
Microsoft.DotNet.XHarness.TestRunners.Common.<version>.nupkgand.Xunit.<version>.nupkg<description>and<tags>from the csproj valuesMotivation (consumer perspective)
On a downstream MAUI Android device-test project (.NET 10,
net10.0-android36.1) I upgraded toMicrosoft.DotNet.XHarness.CLI 11.0.0-prerelease.26217.1and confirmed the--enable-coverageflag from #1565 is accepted and wired through toam instrument. Tests run cleanly, but no Cobertura file is produced because the test app still linksMicrosoft.DotNet.XHarness.TestRunners.Xunit 1.0.0-prerelease.23252.4— which predatesCoverageManager. Once TestRunners publishing resumes, the end-to-end flow will work.Happy to revise scope if the maintainers prefer a different shape.