Skip to content

[Scheduled Run] Localized resource files from OneLocBuild - #4511

Merged
mdaigle merged 1 commit into
mainfrom
dev/automation/onelocbuild-20260807-182109
Aug 7, 2026
Merged

[Scheduled Run] Localized resource files from OneLocBuild#4511
mdaigle merged 1 commit into
mainfrom
dev/automation/onelocbuild-20260807-182109

Conversation

@cheenamalhotra

Copy link
Copy Markdown
Member

Automated PR created from the OneLocBuild scheduled pipeline run.

Contains updated localized Strings.*.resx resource files.

@cheenamalhotra
cheenamalhotra requested a review from a team as a code owner August 7, 2026 18:21
Copilot AI review requested due to automatic review settings August 7, 2026 18:21
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Aug 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This scheduled OneLocBuild PR updates localized resource (Strings.*.resx) files in src/Microsoft.Data.SqlClient by adding a new connection-pool-related resource key.

Changes:

  • Adds SQL_ConnectionPoolReplaceConnectionFailed to multiple localized .resx files.
  • Introduces an English message value for that key across the localized resources (appears to be missing translations).

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
src/Microsoft.Data.SqlClient/src/Resources/Strings.zh-Hant.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.zh-Hans.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.tr.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.ru.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.pt-BR.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.pl.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.ko.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.ja.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.it.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.fr.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.es.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.de.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).
src/Microsoft.Data.SqlClient/src/Resources/Strings.cs.resx Adds SQL_ConnectionPoolReplaceConnectionFailed entry (value currently English).

Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.zh-Hans.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.zh-Hant.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.tr.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.ru.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.pt-BR.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.it.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.fr.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.es.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.de.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.cs.resx
@mdaigle
mdaigle enabled auto-merge (squash) August 7, 2026 22:17
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.82%. Comparing base (deabcc2) to head (f28a614).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4511      +/-   ##
==========================================
- Coverage   64.71%   62.82%   -1.89%     
==========================================
  Files         288      283       -5     
  Lines       44088    67041   +22953     
==========================================
+ Hits        28532    42120   +13588     
- Misses      15556    24921    +9365     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 62.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaigle
mdaigle merged commit 9b20e5e into main Aug 7, 2026
361 of 362 checks passed
@mdaigle
mdaigle deleted the dev/automation/onelocbuild-20260807-182109 branch August 7, 2026 23:57
@github-project-automation github-project-automation Bot moved this from To triage to Done in SqlClient Board Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants