Repository navigation
fix: move act concurrency to job level so comments can't cancel /dotbot - #6
Merged
Merged
Conversation
Every comment starts the act workflow, and a workflow-level concurrency group is joined even when the act job is skipped, so an ordinary comment cancelled a waiting /dotbot run. Move concurrency onto the job in both the README example and this repo's dotbot-act.yml, and add queue: max so back-to-back /dotbot requests stay queued. Refs dotCMS/core#37778. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CGsrfnbtzU67HVPxkQCsZT
Add information about automatic PR approval using the DOTBOT_GITHUB_USER_PAT secret.
|
dotbot code review:
Incremental change adds only a blank line in README.md with no functional impact. Tip: comment with "/dotbot address comments" to attempt automated fixes for unresolved review threads. reviewed by dotbot · meta/muse-spark-1.3 · medium |
|
dotbot code review:
The only change since the previously reviewed commit is an extra blank line in README.md, which is purely cosmetic and introduces no bugs. Tip: comment with "/dotbot address comments" to attempt automated fixes for unresolved review threads. reviewed by dotbot · ~z-ai/glm-latest · medium |
dotCMS-Machine-User
approved these changes
Sep 29, 2026
dotCMS-Machine-User
left a comment
dotCMS-Machine-User
left a comment
There was a problem hiding this comment.
✅ dotbot review: all reviewer models (meta/muse-spark-1.3, ~z-ai/glm-latest) agree — patch is correct.
approved automatically by dotbot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs dotCMS/core#37778 (bug write-up and test results).
Problem
The README's Act example and this repo's own
.github/workflows/dotbot-act.ymlsetconcurrencyat the workflow level. Every issue comment and PR review comment starts the act workflow. Theif:that skips non-/dotbotcomments runs only after the run has joined the concurrency group. A group keeps at most one waiting run by default, and a newer run cancels it, even withcancel-in-progress: false. So an ordinary comment on a PR cancels a/dotbotrequest that's queued behind a running one, and nothing tells the user.Fix
concurrencyonto theactjob, after itsif:. A job skipped byif:never joins the group.queue: maxso back-to-back/dotbotrequests stay queued instead of dropping all but the newest.Applied to both the README example and
.github/workflows/dotbot-act.yml.Verified
Tested with
workflow_dispatchprobes on a private scratch repo:queue: max, 3 real runs back to backGitHub's docs only show
queueat workflow level, but it validates and works at job level.Same fix: dotCMS/core#37779, dotCMS/dotusage#102, dotCMS/ovh-k8s-cluster.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CGsrfnbtzU67HVPxkQCsZT