Remove useSqlBuilder#900
Open
eric-richardson1 wants to merge 9 commits into
Open
Conversation
| loading?: boolean; | ||
| }; | ||
|
|
||
| function showCreateQuery( |
Collaborator
Author
There was a problem hiding this comment.
gonna follow up with a PR that makes this use graphql queries like everything else.
tbantle22
reviewed
May 13, 2026
tbantle22
left a comment
tbantle22
left a comment
Collaborator
There was a problem hiding this comment.
Some questions/comments
Comment on lines
+25
to
+26
| const { executedQueryString } = useDataTableContext(); | ||
| const queryString = props.params.q || executedQueryString || ""; |
Collaborator
There was a problem hiding this comment.
Will this still work for history/diff queries?
Comment on lines
+62
to
+64
| const commitExample = isPostgres | ||
| ? "SELECT DOLT_COMMIT('-am', 'Add docs');" | ||
| : "CALL DOLT_COMMIT('-am', 'Add docs');"; |
Collaborator
There was a problem hiding this comment.
Can you use callProcedure in MergeConflictsDirections for this too? Should move that function to lib
Comment on lines
-41
to
-43
| if (!params.tableName || isDoltSystemTable(params.tableName)) { | ||
| return addEmptyLines([defaultQuery]); | ||
| } |
| <> | ||
| <DataTableLayout params={params} tableName={props.params.tableName}> | ||
| <WithContext params={{ ...props.params, q: params.q }} /> | ||
| <WithContext params={params} /> |
Collaborator
There was a problem hiding this comment.
Should q now be optional or removed from params in the WithContext props?
| className={cx(css.item, { [css.selected]: viewingQuery })} | ||
| > | ||
| <Btn onClick={executeView} className={css.button}> | ||
| <Link {...route} className={css.button}> |
Collaborator
There was a problem hiding this comment.
When I click on a view I no longer stay in the Views tab in the left nav. It takes me to Tables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.