feat(pass): add optional client timeout to run command - #610
Merged
Conversation
Add a RunOption to RunCommand so callers can forward a request timeout to client.New via client.WithTimeout. When the option is not provided, the client's default request timeout applies; a timeout of 0 disables the request timeout. Signed-off-by: Johannes Großmann <grossmann.johannes@t-online.de>
joe0BAB
marked this pull request as ready for review
August 6, 2026 11:21
docker-agent
reviewed
Aug 6, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The implementation is clean and correct. Key points verified by the review:
- Pointer-to-Duration for zero-value semantics:
*time.Durationcorrectly distinguishes "option not provided" (nil) from "timeout of 0" (disables the request timeout), matching the documented behavior. - No aliasing bug: The option closure captures the duration value before taking its address — safe and idiomatic Go.
- Correct nil guard:
client.WithTimeoutis only appended when the option is non-nil, preserving the default client timeout when no option is passed. go.work.sum: Only checksum additions for transitive dependencies — no logic changes.
No bugs, logic errors, resource leaks, or security issues introduced by this PR.
Benehiko
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a RunOption to RunCommand so callers can forward a request timeout to client.New via client.WithTimeout. When the option is not provided, the client's default request timeout applies; a timeout of 0 disables the request timeout.