guides (python, deno, bun): update to dhi-only and remove external repo#25184
guides (python, deno, bun): update to dhi-only and remove external repo#25184craig-osterhout wants to merge 4 commits into
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
One high-severity content accuracy issue found: the requirements.txt shown in python/containerize.md omits uvicorn, which is required by the Dockerfile's CMD. Users following the guide will build a container that immediately fails to start. See inline comment for details and fix.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
|
/review |
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
This PR cleanly removes the external sample-repo dependency and replaces it with inline "create the application" steps for the Bun, Deno, and Python guides, and migrates all three to DHI-only base images. The approach is well-structured. A couple of items to fix:
Additional note (can't pin inline — unchanged context lines):
In content/guides/python/containerize.md and content/guides/python/develop.md, the directory tree listings use single-space indentation after │ (e.g., │ ├── app.py) rather than the three-space format used in the Bun and Deno guides added in this same PR (e.g., │ ├── app.py). These are pre-existing context lines so they can't be commented inline, but they're worth fixing for consistency.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR cleanly migrates the Bun, Deno, and Python guides to DHI-only and removes the external git clone dependency. The changes are well-structured, the Dockerfile multi-stage build pattern is correct, port numbers are consistently updated (8001→8000), and the Kubernetes manifests are properly aligned. Two minor findings noted via inline comments.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Description
Doing a couple of easy guides plus the popular Python guide to get some feedback and agent-priming before tackling the other guides.
Related issues or tickets
ENGDOCS-3308
Reviews