Skip to content

guides (python, deno, bun): update to dhi-only and remove external repo#25184

Open
craig-osterhout wants to merge 4 commits into
docker:mainfrom
craig-osterhout:dhi-all-the-things-1
Open

guides (python, deno, bun): update to dhi-only and remove external repo#25184
craig-osterhout wants to merge 4 commits into
docker:mainfrom
craig-osterhout:dhi-all-the-things-1

Conversation

@craig-osterhout
Copy link
Copy Markdown
Contributor

Description

Doing a couple of easy guides plus the popular Python guide to get some feedback and agent-priming before tackling the other guides.

  • Updated guides to DHI-only. DHI Community is now free.
  • Updated guides away from git clone. Maintaining and updating separate repos is a burden. It's a bit more copy-paste for users, so will monitor feedback closely. Pondering a faux file browser & copy-paste-to-create-all-files component to make the UX slicker for scaffolding samples.
  • Updated the Python linting and typing topic to offer a container-based alternative to installing tools locally.

Related issues or tickets

ENGDOCS-3308

Reviews

  • Editorial review

Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit fa4a9ed
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a1749a70e1b5f00082c1a80
😎 Deploy Preview https://deploy-preview-25184--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🔴 CRITICAL

One high-severity content accuracy issue found: the requirements.txt shown in python/containerize.md omits uvicorn, which is required by the Dockerfile's CMD. Users following the guide will build a container that immediately fails to start. See inline comment for details and fix.

Comment thread content/guides/python/containerize.md
Comment thread content/guides/bun/containerize.md Outdated
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
@craig-osterhout
Copy link
Copy Markdown
Contributor Author

/review

Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Comment thread content/guides/python/develop.md Outdated
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Comment thread content/guides/python/deploy.md Outdated
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Comment thread content/guides/python/lint-format-typing.md Outdated
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

This PR cleanly removes the external sample-repo dependency and replaces it with inline "create the application" steps for the Bun, Deno, and Python guides, and migrates all three to DHI-only base images. The approach is well-structured. A couple of items to fix:

Additional note (can't pin inline — unchanged context lines):

In content/guides/python/containerize.md and content/guides/python/develop.md, the directory tree listings use single-space indentation after (e.g., │ ├── app.py) rather than the three-space format used in the Bun and Deno guides added in this same PR (e.g., │ ├── app.py). These are pre-existing context lines so they can't be commented inline, but they're worth fixing for consistency.

Comment thread content/guides/python/develop.md Outdated
Comment thread content/guides/python/lint-format-typing.md Outdated
Comment thread content/guides/python/deploy.md Outdated
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR cleanly migrates the Bun, Deno, and Python guides to DHI-only and removes the external git clone dependency. The changes are well-structured, the Dockerfile multi-stage build pattern is correct, port numbers are consistently updated (8001→8000), and the Kubernetes manifests are properly aligned. Two minor findings noted via inline comments.

Comment thread content/guides/python/develop.md Outdated
Comment thread content/guides/python/containerize.md
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants