Repository navigation
Conversation
Pre-release test of the go-yaml v4 release candidate ahead of v4.0.0, as requested in docker#14432. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
docker-agent
reviewed
Nov 2, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
docker-agent
reviewed
Nov 2, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Nov 2, 2026
Contributor
Author
|
Superseded by #14446, which tests go-yaml v4.0.0-rc.9 (includes the fix from yaml/go-yaml#475). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does, in one sentence
Bumps
go.yaml.in/yaml/v4to thev4.0.0-rc.8release candidate so that CI runs Compose's unit and e2e suites against it before go-yaml v4.0.0 ships.Context
The go-yaml maintainers plan to release v4.0.0 on November 4, 2026 and asked downstream projects to test the release candidates beforehand (#14432). Compose depends on go-yaml v4 directly (config rendering, bridge conversion, transform) and, through compose-go, for loading and marshalling Compose files. It currently pins
v4.0.0-rc.6.What the PR brings
Only the
go.mod/go.sumbump. A green CI means Compose's YAML parsing and serialization checks pass with rc.8 and the result can be reported on yaml/go-yaml#469; a red one gives the maintainers a concrete failure to look at.Compose builds compose-go with the go-yaml version selected here, so this PR also exercises compose-go's code paths against rc.8. The matching compose-go PR is compose-spec/compose-go#981.
This is a test PR: it is opened as a draft and is not meant to be merged before the final v4.0.0 is published.
Part of #14432
🤖 Generated with Claude Code