fix: Properly deserialise loopback edges - #2599
Merged
rprospero merged 1 commit intoSep 4, 2026
Merged
Conversation
Ensure that loaded graph has correct number of loopbacks Fixup Actual fix
RobBuchananCompPhys
approved these changes
Sep 4, 2026
RobBuchananCompPhys
left a comment
RobBuchananCompPhys
left a comment
Contributor
There was a problem hiding this comment.
I haven't tested this out locally, so I assume the tests added here are passing, but this looks spot on! 👍
trisyoungs
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue with deserialising the loopback edges. I've also added a small test to confirm that the number of loopback edges are correct after the roundtrip.
The extra test is because I briefly thought that I had solved the problem, but found that I had merely prevented loopbacks from exporting, so both the original and the roundtrip showed no loopbacks and the test passed, despite the roundtrip not actually reconstructing the same graph.