Skip to content

feat(devops): Add GitHub linter - #125

Merged
bitdivine merged 7 commits into
mainfrom
zizmor
Sep 25, 2025
Merged

bitdivine merged 7 commits into
mainfrom
zizmor

Conversation

@bitdivine

@bitdivine bitdivine commented Sep 25, 2025 •

Copy link
Copy Markdown
Contributor

Motivation

For security auditing, we use the zizmor linter for GitHub actions.

Zizmor has detected issues with eth current GitHub setup, so we start off by adding it but not enforcing it. Once we have addressed the issues identified by zizmor, we can enforce the lints.

Changes

  • Add zizmor to the list of dev tools.
  • Add a GitHub task (unenforced) that runs the zizmor linter.
  • Add the zizmor linter to the overall lint command, but unenforced.

Tests

The code is the same as for oisy-wallet, only with the lint command renamed to match the conventions in this repo.

dependabot Bot and others added 5 commits September 25, 2025 11:14
Bumps [@dfinity/auth-client](https://github.com/dfinity/icp-js-core/tree/HEAD/packages/auth-client) from 2.4.1 to 3.2.6.
- [Release notes](https://github.com/dfinity/icp-js-core/releases)
- [Changelog](https://github.com/dfinity/icp-js-core/blob/main/CHANGELOG.md)
- [Commits](https://github.com/dfinity/icp-js-core/commits/HEAD/packages/auth-client)

---
updated-dependencies:
- dependency-name: "@dfinity/auth-client"
  dependency-version: 3.2.6
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@bitdivine
bitdivine enabled auto-merge (squash) September 25, 2025 12:22

@DecentAgeCoder DecentAgeCoder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@DecentAgeCoder DecentAgeCoder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@bitdivine
bitdivine merged commit 9c2c907 into main Sep 25, 2025
12 of 13 checks passed
@bitdivine
bitdivine deleted the zizmor branch September 25, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants