Repository navigation
docs: correct Store build and WACK verification instructions - #4
Conversation
Generated-with: gpt-6.1-sol (Codex)
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
|
Independent review by gpt-6.1-sol (separate instance), exact head 5b3883b. Full two-file diff and complete updated BUILD guide read; checked against pyproject.toml, build_exe.bat and the preflight/report-review code. The guide now matches Python >=3.12 and build extras, the mandatory external scanner and explicit dist override, absence of startup/Authenticode checks, manual staging and SDK validation without /nv. The WACK boundary is accurate: --msix still only generates static preflight XML/JSON, while --review-wack-report parses a report. Windows Python 3.12: all 11 tests/test_store_materials.py tests and git diff --check passed. An isolated synthetic --msix invocation generated only static XML/JSON, did not look up appcert, and its report parsed successfully; fixture removed. German UTF-8 umlauts intact. No blocking finding in this documentation correction. No EXE/MSIX build, signing, WACK execution, Store certification/submission or full repository test claim. Existing exact-head Python 3.12/3.13 and CodeQL checks are successful. Explicit Draft-only/merge-disabled hold preserved. |
The public Store build guide required Python 3.11 although the package requires 3.12+, invoked an unavailable private workstation script, promised a different EXE output and verification behavior, and described a static material preflight as WACK certification.
Document the actual external scanner prerequisite, explicit output override and staging requirement. Replace private absolute commands with repository-relative Windows SDK packaging, retain SDK validation, and distinguish static preflight reports from separately executed WACK and Store certification.
Validation: all 11 existing Store-material tests pass on Windows Python 3.12; git diff --check passes. Instructions were checked against pyproject.toml, build_exe.bat and scripts/run_windows_wack.py. No executable/MSIX was built, signed, certified or submitted. No product version or runtime behavior changed.
This is a scoped documentation correction found during care preflight, not a claim of completed full repository care. Other care findings remain outside this PR. Author model: gpt-6.1-sol (Codex). Independent model review pending. Draft only; merges disabled.