Skip to content

chore(api): use pymemcache instead of pylibmc #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterthomassen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(api): use pymemcache instead of pylibmc #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ While there are certainly many ways to get started hacking desec-stack, here is
jq, httpie, libmariadbclient-dev, libpq-dev, python3-dev (>= 3.12) and python3-venv (>= 3.12) are useful if you want to follow this guide.
The webapp requires Node.js. To install everything you need for this guide except docker and docker compose, use

sudo apt install certbot curl git httpie jq libmariadbclient-dev libpq-dev nodejs npm python3-dev python3-venv libmemcached-dev
sudo apt install certbot curl git httpie jq libmariadbclient-dev libpq-dev nodejs npm python3-dev python3-venv

1. **Get the code.** Clone this repository to your favorite location.

Expand Down
2 changes: 1 addition & 1 deletion api/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ ENV PIP_NO_CACHE_DIR=1

COPY requirements.txt /usr/src/app/
# freetype-dev is needed for captcha generation
RUN apk add --no-cache gcc freetype-dev libffi-dev musl-dev libmemcached-dev postgresql-dev jpeg-dev zlib-dev
RUN apk add --no-cache gcc freetype-dev libffi-dev musl-dev postgresql-dev jpeg-dev zlib-dev
RUN pip install --upgrade pip \
&& pip install -r requirements.txt \
&& pip freeze
Expand Down
7 changes: 5 additions & 2 deletions api/api/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,12 @@

CACHES = {
"default": {
# TODO 'BACKEND': 'django_prometheus.cache.backends.memcached.PyLibMCCache' not supported
"BACKEND": "django.core.cache.backends.memcached.PyLibMCCache",
# Django closes cache connections at the end of each request, so this backend
# reconnects to memcached per request. Subclassing it with a no-op close()
# keeps the connection open, should the reconnects ever become noticeable.
"BACKEND": "django.core.cache.backends.memcached.PyMemcacheCache",
"LOCATION": "memcached:11211",
"OPTIONS": {"no_delay": True},
}
}

Expand Down
2 changes: 1 addition & 1 deletion api/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dnspython~=2.8.0
pyotp~=2.9.0
psycopg[binary]~=3.3.4
psl-dns~=1.1.1
pylibmc~=1.6.3
pymemcache~=4.0.0
pyyaml~=6.0.3
requests~=2.32.5
responses~=0.26.2
Expand Down
Loading