ci: make All Checks Passed gate fail instead of skip#1592
Merged
Conversation
The required status check `All Checks Passed` (job `done`) used an `if` condition that evaluated false whenever a dependency failed, causing the job to be skipped. Branch protection treats a skipped required check as satisfied, so failing PRs could merge (e.g. #1584). Run the job unconditionally and explicitly exit 1 when any dependency fails or is cancelled, so the gate reports a real failure conclusion. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MZttWkoiN7iRQqRSzyDM77
|
🐕 Review complete — View session on Shuni Portal 🐾 |
dorsha
approved these changes
Jun 27, 2026
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Makes the All Checks Passed gate run unconditionally and explicitly exit 1 when any dependency failed or was cancelled, so branch protection sees a real failure instead of a skip.
No issues found — good bones! The if: always() + explicit failure step is the correct GitHub Actions pattern for this gate. Woof!
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required status check
All Checks Passed(jobdone) used anifcondition that evaluated false whenever a dependency failed, causing the
job to be skipped. Branch protection treats a skipped required check as
satisfied, so failing PRs could merge (e.g. #1584).
Run the job unconditionally and explicitly exit 1 when any dependency
fails or is cancelled, so the gate reports a real failure conclusion.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01MZttWkoiN7iRQqRSzyDM77