Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # ext/web/lib.rs # runtime/js/98_global_scope_shared.js # runtime/js/98_global_scope_window.js # runtime/js/98_global_scope_worker.js
…resource cleanup - Move locks.js to lazy_loaded_esm, use createLazyLoader for Lock/LockManager globals - Replace dedicated thread + tokio runtime with simple Mutex<LockState> - Fix client_id: use per-OpState atomic counter instead of thread name - Fix steal: properly drain and reject pending requests for stolen lock name - Add AbortSignal support: split into sync request + async await + cancel ops - Add resource cleanup: HeldLockResource/PendingLockResource impl Drop to release/cancel on worker termination - Fix ifAvailable: return explicit status instead of silently dropping sender - Make query() and release() synchronous
# Conflicts: # ext/web/lib.rs # runtime/js/98_global_scope_shared.js # runtime/js/98_global_scope_window.js
Deno Individual Contributor License AgreementThe following contributors need to sign the CLA before this PR can be merged: Click here to review and sign the CLA | Re-run CLA check This is an automated message from CLA Assistant |
…s names - Notify lock holders when their lock is stolen so request() rejects with AbortError, and keep the event loop alive while a lock is held (new op_lock_manager_await_steal). This fixes the WPT file failures in steal/signal where held-forever locks drained the event loop before the harness completed. - Don't abort pending requests on steal; the stealing request jumps the queue but other waiters remain queued (per spec). - Process a synchronously-signaled abort on an immediately-granted lock by yielding a microtask and re-checking the signal. - Escape lone surrogates in lock names so distinct DOMStrings don't collide as keys (fixes resource-names deadlock). - Update web-locks WPT expectations accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15905