fix(vtex/plp): type productListingPage return as ProductListingPage#81
Open
guitavano wants to merge 1 commit into
Open
fix(vtex/plp): type productListingPage return as ProductListingPage#81guitavano wants to merge 1 commit into
guitavano wants to merge 1 commit into
Conversation
The PLP inline loader returned `Promise<any | null>`, preventing the schema generator from resolving its output type. Change to `Promise<ProductListingPage | null>` and add the missing `canonical` field to `pageTypesToSeo` so the return value satisfies the interface. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
productListingPagereturn type fromPromise<any | null>toPromise<ProductListingPage | null>canonicalfield topageTypesToSeoto satisfy theSeointerfaceSearchResult.page) include it in their anyOf pickerTest plan
generate-schema.tslocally —productListingPagenow resolves as→ ProductListingPageSearchResult.pageanyOf includesvtex/loaders/intelligentSearch/productListingPage.ts🤖 Generated with Claude Code
Summary by cubic
Typed the VTEX PLP loader to return
ProductListingPage | nulland filled the missing SEOcanonical. This lets the schema generator resolve the PLP output and surface it in pickers likeSearchResult.page.productListingPagefromPromise<any | null>toPromise<ProductListingPage | null>.pageTypesToSeoand addedcanonicalto satisfy theSeointerface.Written for commit 56e776e. Summary will update on new commits.