Repository navigation
fix: set SQL Server compatible default for insert batch size - #622
Open
danielkroeders wants to merge 2 commits into
Open
danielkroeders wants to merge 2 commits into
danielkroeders wants to merge 2 commits into
Conversation
danielkroeders
requested review from
a team,
b-per and
graciegoheen
as code owners
November 7, 2026 13:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a:
Description & motivation
SQL Server has a limitation of 1,000 row-value expressions per
INSERT ... VALUESstatement.The default
insert_batch_sizeconfiguration can exceed this limit, causing SQL Server to raise the following error when running theinsert_resources_from_graphmacro:The number of row value expressions in the INSERT statement exceeds the maximum allowed number of 1000 row values. (10738)This PR introduces adapter-specific defaults for
insert_batch_sizeto prevent this issue:This ensures that generated INSERT statements respect SQL Server's row limit while retaining configurable batch sizes for other adapters.
Checklist
./integration_tests_checks/run_checks.shpasses locallydocs/(if applicable)integration_tests_checks/and itsexpected_violations.csv(if applicable)