Repository navigation
perf: share Iceberg ArrowReader across scan partitions - #817
Merged
alexanderbianchi merged 1 commit intoOct 30, 2026
Merged
alexanderbianchi merged 1 commit into
alexanderbianchi merged 1 commit into
Conversation
alexanderbianchi
marked this pull request as ready for review
October 28, 2026 23:56
| } | ||
|
|
||
| /// Two data files, each with its first row removed by one shared delete file. | ||
| fn files_with_shared_deletes(directory: &TempDir) -> Result<DeleteFixture, Box<dyn Error>> { |
Collaborator
Author
There was a problem hiding this comment.
@gabotechs this should be easier with your new harness
Collaborator
There was a problem hiding this comment.
👍 Yeah, I think this is a good opportunity to add support for delete files in the harness, I see it's still not done here.
gabotechs
approved these changes
Oct 30, 2026
gabotechs
left a comment
gabotechs
left a comment
Collaborator
There was a problem hiding this comment.
👍 Looks good. I'd give it a try to add support for building delete files in the harness, but otherwise looks good.
alexanderbianchi
force-pushed
the
codex/share-iceberg-arrow-reader
branch
from
October 30, 2026 18:13
0f0835e to
0092688
Compare
alexanderbianchi
merged commit Oct 30, 2026
ba454c0
into
datafusion-contrib:main
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iceberg scans currently build a new
ArrowReaderfor every output partition, giving each partition a separate delete-file cache. Retain a reader in the shared scan configuration and clone it when opening partitions, so eager and lazy scans reuse loaded deletes within a process.Reader settings are captured from the context when planning or reconstructing a scan. Worker decoding still constructs its own reader with worker-local FileIO, runtime, and settings. Source clones and regrouped eager scans share that reader; the wire format is unchanged.
Validation:
integrationfeature, including distributed eager/lazy execution.Draft pending performance qualification; no end-to-end speedup is claimed.