Skip to content

added goldens#2109

Open
Ashwani725 wants to merge 1 commit into
datacommonsorg:masterfrom
Ashwani725:added_goldens
Open

added goldens#2109
Ashwani725 wants to merge 1 commit into
datacommonsorg:masterfrom
Ashwani725:added_goldens

Conversation

@Ashwani725

@Ashwani725 Ashwani725 commented Jul 22, 2026

Copy link
Copy Markdown

Jobs ran successfully. Added Golden Checks.
Files added are : golden_data/, manifest.json, validation_config.json

@google-cla

google-cla Bot commented Jul 22, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces validation configuration and golden data files for the India NDAP Life Expectancy import. Specifically, it adds validation_config.json with rules for deleted records percentage and golden data checks, updates manifest.json to reference this configuration, and provides the corresponding golden observation and summary report CSV files. Feedback is provided regarding the Wikidata ID used for Delhi in the golden observations, which should be updated to Q9357528 instead of Q1353 to match the repository's mapping rules for Indian administrative data at the AA1 level.

Comment thread statvar_imports/india_ndap/ndap/golden_data/golden_observations.csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant