Fix date mappings in pvmap for NCES STEM degrees import#2102
Open
smarthg-gi wants to merge 4 commits into
Open
Fix date mappings in pvmap for NCES STEM degrees import#2102smarthg-gi wants to merge 4 commits into
smarthg-gi wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the NCES STEM Degrees dataset import by revising the documentation in README.md, updating academic year mappings in pvmap.csv, adding a validation configuration (validation_config.json), and introducing golden data files for verification. It also updates the processing script arguments in manifest.json. Feedback on the pull request identifies an incorrect command-line flag --config in the README.md documentation, which should be updated to --config_file to match the actual script configuration.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import name =
NCES_STEM_Degrees_ImportOverview
Updated mapping for NCES_STEM_Degrees_Import under
statvar_imports/.Key Changes
test_data/.Verification & Validation Proofs
Verification:
stat_var_processor.pyexecuted againsttest_data/*.Data Commons Lint Check: Executed
java -jar datacommons-import-tool.jar lint output_files/*.csv.Result: 0 errors. All generated StatVar DCIDs and TMCF references conform to schema rules.