fix: release builds warnings removed#825
Conversation
|
Warning Review limit reached
More reviews will be available in 45 minutes and 27 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR changes ChangesClippy profile execution
Structured error logging
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
dash/src/consensus/serde.rs (1)
197-201: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRetitle or split this PR.
These logging changes alter runtime behavior, so they do not fit a cleanup-only title like
fix: release builds warnings removed. Either widen the title/description or move the tracing changes into a separate focused PR. As per path instructions, "Check whether the PR title prefix allowed in the pr-title.yml workflow accurately describes the changes" and "If a PR mixes unrelated concerns ... suggest splitting it into separate focused PRs."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@dash/src/consensus/serde.rs` around lines 197 - 201, The change in serde::error! logging affects runtime behavior, so the current cleanup-only PR framing is inaccurate; either update the PR title/description to match the tracing/runtime behavior changes or split the logging/tracing updates into a separate focused PR from the warning cleanup. Use the existing serde::error! formatting path and related tracing changes as the boundary when deciding what stays together.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@dash/src/consensus/serde.rs`:
- Around line 197-201: DisplayWrapper::fmt in consensus/serde.rs is logging
directly inside formatting, which can re-enter tracing and cause deadlocks or
recursion. Remove the tracing::error! call from Display::fmt and make it return
fmt::Error unconditionally on formatting failure, then move the error logging to
the caller that invokes DisplayWrapper::fmt so the logging happens outside the
formatting path.
In `@dash/src/sml/quorum_entry/validation.rs`:
- Line 54: The validation loop in
quorum_entry::validation::verify_aggregated_commitment_signature is logging an
error for every rejected operator key, which creates noisy N-times logging for a
single failed validation. Change this path to stop emitting an error inside the
per-masternode closure and instead propagate the first deserialization failure
as QuorumValidationError from the outer validation flow, or downgrade/throttle
the log if repeated best-effort filtering is intended. Use the existing error
handling around verify_aggregated_commitment_signature and the
QuorumValidationError variants to keep the failure surfaced once.
---
Nitpick comments:
In `@dash/src/consensus/serde.rs`:
- Around line 197-201: The change in serde::error! logging affects runtime
behavior, so the current cleanup-only PR framing is inaccurate; either update
the PR title/description to match the tracing/runtime behavior changes or split
the logging/tracing updates into a separate focused PR from the warning cleanup.
Use the existing serde::error! formatting path and related tracing changes as
the boundary when deciding what stays together.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4a23df63-c4a4-4d46-9d6c-4dc9c340f04c
📒 Files selected for processing (3)
contrib/run_clippy.pydash/src/consensus/serde.rsdash/src/sml/quorum_entry/validation.rs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #825 +/- ##
==========================================
- Coverage 73.19% 73.17% -0.02%
==========================================
Files 323 323
Lines 72294 72295 +1
==========================================
- Hits 52912 52901 -11
- Misses 19382 19394 +12
|
ZocoLini
force-pushed
the
fix/release-warnings
branch
from
15e3828 to
e4abbcb
Compare
2 participants
Summary by CodeRabbit