feat(dash-dex): add buy swap part 1#1502
Open
HashEngineering wants to merge 4 commits into
Open
Conversation
Add a shortcut button that navigates directly into the DashDEX (Maya) portal. Uses the SwapKit emblem recoloured to Dash brand blue. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughThe PR adds a Dash DEX home shortcut and wires it into the Maya integration. It introduces buy/sell direction state, updates the Maya portal UI and navigation, and changes the crypto picker to branch on the selected direction. ChangesDash DEX shortcut and Maya flow
Sequence Diagram(s)sequenceDiagram
participant MayaPortalScreen
participant MayaPortalFragment
participant MayaViewModel
participant MayaCryptoCurrencyPickerFragment
MayaPortalScreen->>MayaPortalFragment: onBuyClick() / onSellClick()
MayaPortalFragment->>MayaViewModel: setSwapDirection(BUY or SELL)
MayaCryptoCurrencyPickerFragment->>MayaViewModel: read swapDirection
alt SELL
MayaCryptoCurrencyPickerFragment->>MayaCryptoCurrencyPickerFragment: navigate to address input screen
else BUY
MayaCryptoCurrencyPickerFragment->>MayaCryptoCurrencyPickerFragment: show AdaptiveDialog("Buy Swap")
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
HashEngineering
changed the title
Collaborator
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
integrations/maya/src/main/java/org/dash/wallet/integrations/maya/ui/MayaViewModel.kt (1)
156-165: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚖️ Poor tradeoffDirection state added as a standalone flow rather than folded into a UIState.
_swapDirection/swapDirectionare correctly exposed (private mutable +asStateFlow(),StateFlow), but they add yet another separate flow to a ViewModel that the guidelines say should converge on a singleUIStatedata class. This matches the file's existing pattern, so consider it non-blocking, but worth noting for future consolidation.As per coding guidelines: "ViewModels should use a single
UIStatedata class rather than multiple separate flows".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@integrations/maya/src/main/java/org/dash/wallet/integrations/maya/ui/MayaViewModel.kt` around lines 156 - 165, The swap direction is currently exposed as its own MutableStateFlow/StateFlow pair in MayaViewModel, but the ViewModel should converge on a single UIState model. Fold _swapDirection and swapDirection into the existing UIState data class and update setSwapDirection to mutate that state instead of maintaining a separate flow.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@integrations/maya/src/main/java/org/dash/wallet/integrations/maya/ui/MayaCryptoCurrencyPickerFragment.kt`:
- Around line 91-92: The “navigating to address input” log in
MayaCryptoCurrencyPickerFragment’s onCurrencySelected flow is misleading because
it runs before the SwapDirection.SELL check even though the BUY path shows a
dialog instead of navigating. Move the log into the SELL branch that performs
the navigation, or change the message to describe the shared selection step, so
the log matches the actual behavior in this fragment and its viewModel
swapDirection logic.
In `@wallet/src/de/schildbach/wallet/ui/main/WalletFragment.kt`:
- Around line 409-412: The Dash DEX shortcut path in WalletFragment’s shortcut
handling jumps directly to homeToMaya() without setting the swap backend first,
which can leave stale provider state active. Update this ShortcutOption.DASH_DEX
branch to reuse the same backend-selection flow used by buySellToMaya(),
explicitly selecting SwapBackend.MAYA/SWAPKIT before navigation, then continue
through the existing navigation path.
---
Nitpick comments:
In
`@integrations/maya/src/main/java/org/dash/wallet/integrations/maya/ui/MayaViewModel.kt`:
- Around line 156-165: The swap direction is currently exposed as its own
MutableStateFlow/StateFlow pair in MayaViewModel, but the ViewModel should
converge on a single UIState model. Fold _swapDirection and swapDirection into
the existing UIState data class and update setSwapDirection to mutate that state
instead of maintaining a separate flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a50cefae-f631-4958-88b3-237bcbdd4449
📒 Files selected for processing (17)
common/src/main/java/org/dash/wallet/common/services/analytics/AnalyticsConstants.ktintegrations/maya/src/main/java/org/dash/wallet/integrations/maya/ui/MayaCryptoCurrencyPickerFragment.ktintegrations/maya/src/main/java/org/dash/wallet/integrations/maya/ui/MayaPortalFragment.ktintegrations/maya/src/main/java/org/dash/wallet/integrations/maya/ui/MayaPortalScreen.ktintegrations/maya/src/main/java/org/dash/wallet/integrations/maya/ui/MayaViewModel.ktintegrations/maya/src/main/java/org/dash/wallet/integrations/maya/utils/SwapBackend.ktintegrations/maya/src/main/java/org/dash/wallet/integrations/maya/utils/SwapDirection.ktintegrations/maya/src/main/res/drawable/ic_dash_dex_buy.xmlintegrations/maya/src/main/res/drawable/ic_dash_dex_illustration.xmlintegrations/maya/src/main/res/drawable/ic_dash_dex_sell.xmlintegrations/maya/src/main/res/navigation/nav_maya.xmlintegrations/maya/src/main/res/values/strings-maya.xmlwallet/res/drawable/ic_shortcut_dash_dex.xmlwallet/res/navigation/nav_home.xmlwallet/res/values/strings-extra.xmlwallet/src/de/schildbach/wallet/ui/main/WalletFragment.ktwallet/src/de/schildbach/wallet/ui/main/shortcuts/ShortcutOption.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist:
Summary by CodeRabbit